Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text style resources reject
textDecoration, and the text style resolver drops it, so an author cannot underline text through a shared text style, and tools that export formatted text have to drop underline.Reproduce: a
resources.textStylesentry withtextDecoration: "underline"fails schema validation, and the rendered text style of an element or rich text run using that style has no decoration (regression tests).Fix: text style resources accept an optional
textDecoration(noneorunderline); the resolver passes it into the rendered text style; the validator is regenerated.Tests: schema acceptance and rejection of unknown values, and render states for plain text, rich text runs referencing the style, and text-revealing. The full suite (2,165 tests), lint, the test-marker check and changed-file formatting pass.
Note: drawing the underline also needs Route Graphics' underline rendering (RouteVN/route-graphics#362); this change makes the engine emit the decoration.