Codex/feature network migration - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to support a new "core" network runtime alongside the existing legacy implementation. The main focus is on enabling the server to operate in either legacy or core network mode, with a new command context abstraction to allow chat commands to work across both. The changes include new context interfaces, migration of command execution logic, and updates to configuration and server startup to support the new network stack.
Core network support and runtime selection:
RukkitConfig.NetworkConfig) and runtime checks (isCoreNetworkEnabled) to select between legacy and core network stacks, with new initialization logic inRukkit.javato create and manage core network components when enabled. [1] [2] [3] [4] [5] [6] [7]Command context abstraction and migration:
ChatCommandContext,ChatCommandContextListener, andRoomCommandContextinterfaces, along with theServerChatCommandContextimplementation, to decouple chat command logic from the underlying network stack and enable shared command semantics for both legacy and core modes. [1] [2] [3] [4]ChatCommandto support context-based commands with new factory methods and listener management, enabling registration and execution of commands compatible with the new context. [1] [2] [3] [4]Command execution improvements:
CommandManagerwith logic to execute chat commands using the new context abstraction for core connections, including permission checks and command echoing, while maintaining compatibility with legacy commands.Other improvements and refactoring:
RoomStartGameEventto support both legacy and core room types, improving event handling compatibility. [1] [2]RoundConfigfor creating independent room configurations from defaults.