fix(auth-center): restrict role assignment in user create and update - #40
Merged
Conversation
avlllo
reviewed
Aug 20, 2026
| return status.Errorf(codes.Unauthenticated, "can't get token: %v", err) | ||
| } | ||
|
|
||
| if token.Role.ID == model.AdminRoleID { |
Collaborator
There was a problem hiding this comment.
last admin can be demoted here. need to additionally check isn't it a last admin user
avlllo
reviewed
Aug 20, 2026
| "can't modify an administrator account").Err() | ||
| } | ||
|
|
||
| if newRoleID != token.Role.ID { |
Collaborator
There was a problem hiding this comment.
role preserving requests will be failed too, i think it should be smth like
if newRoleID != token.Role.ID && newRoleID != currentRoleID {
torkel-hoge
reviewed
Aug 25, 2026
|
|
||
| if newRoleID != token.Role.ID && newRoleID != currentRoleID { | ||
| return errcommon.StatusWithReason(codes.PermissionDenied, RoleAssignmentRestricted, | ||
| "can't assign a role other than your own").Err() |
Collaborator
There was a problem hiding this comment.
what's the point of such limitation? shouldn't admin be able to create users with other roles?
p.s currently, admin and security engineer are allowed to create users. i suggest removing this permission from security engineer, since it doesn't make sense imo. after we do it, we can get rid of this check safely if i'm not mistaken. what do you think?
torkel-hoge
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.