feat: add public cp1252 decode_string/encode_string helpers - #7
Merged
Merged
Conversation
tyler27
force-pushed
the
feat/public-cp1252
branch
from
May 24, 2026 22:43
6cf2a1a to
f96e31e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cp1252::decode_string(&[u8]) -> String— converts CP-1252 bytes to UTF-8cp1252::encode_string(&str) -> Vec<u8>— converts UTF-8 string to CP-1252 bytesThese wrap the existing internal
decode/encodefunctions, following the same pattern asbz2_compress/bz2_decompressandgz_compress/gz_decompress.Needed for cases where CP-1252 data arrives outside of
Packet(e.g. Huffman-decoded chat messages).No breaking changes — purely additive.