fix(0131-FaceNoseTipCenterOffset): measured nose_tip Y as tip; compare vs front surface - #133
Merged
Merged
Conversation
Measured finite nose_tip y_m now seats RECIPE_nose_soft center at y_m + nose_ry (Loomis parity). blockout-face-compare Y for nose_tip uses center[1] - ry_m when ry_m is finite; missing/non-finite ry_m falls back to center. MCP stay 53; no remake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nose_tipy_mnow writes ellipsoid center = tip+ nose_ry(Loomis parity) so the front surface seats on the captured tip.blockout-face-compareY fornose_tipcompares against front surfacecenter[1] - ry_mwhenry_mis finite; missing/non-finitery_mfalls back to center (no NaN)._delta_mm(..., role_id)— production call passeslid(B17). JSONrecipe.centerstays the ellipsoid center (no schema bump).Honesty (N6)
FACE_COMPARE_HONESTY / RECIPE_HONESTY — authoring QA only; green compare ≠ print success. No remake/D7 (Loomis path unchanged; Default Package A still lacks measured nose Y).
Test plan
test_face__nose_tip_y_freezeOut of scope
0137 num_faces max; 0132–0136 leftovers; MCP 54; remake.
Note
Low Risk
Authoring-only face recipe/compare geometry; no schema, auth, or print-path changes. Wrong Y offset would only skew QA deltas and nose placement.
Overview
Treats measured
nose_tipY as the tip, not the ellipsoid center, so the nose soft mass seats with its front surface on the captured landmark.When
y_mis finite,RECIPE_nose_softcenter is nowtip + nose_ry(same offset as the Loomis fallback). Face-compare Y fornose_tipusescenter[1] - ry_mwhenry_mis finite; missing/NaNry_mfalls back to center with no NaN. JSONrecipe.centeris unchanged (still the ellipsoid center).Scale constants (
NOSE_RY_FRAC_H,NOSE_TIP_Y_FRAC_RY) stay frozen. Authoring QA only.Reviewed by Cursor Bugbot for commit 8b100a8. Bugbot is set up for automated code reviews on this repo. Configure here.