feat(0132-SetupLaunchJobBreakaway): --spawn CREATE_BREAKAWAY_FROM_JOB - #134
Merged
Merged
Conversation
NT blockout-open-setup --spawn ORs CREATE_BREAKAWAY_FROM_JOB (getattr + 0x01000000) so GUI Blender survives agent Job Objects. Fail-closed setup_spawn_failed with details.winerror; no silent retry. MCP stay 53.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NT
blockout-open-setup --spawnnow ORsCREATE_BREAKAWAY_FROM_JOB(getattr+0x01000000) so GUI Blender survives agent Job Objects thatKILL_ON_JOB_CLOSE. Fail-closedsetup_spawn_failed(optionaldetails.winerror); no silent retry. POSIXstart_new_sessionunchanged. MCP catalog stay 53. No remake/D7.Why
DETACHED_PROCESSonly severs the console — children still inherit the parent Job. Agent shells then tear down Blender when meshops exits (0110 leftover).Honesty (N6)
Setup launch only — not mesh or print success (
SETUP_LAUNCH_HONESTY).Tests
flags & 0x01000000+ bitwise no-CREATE_NO_WINDOWledgerful verifyPASS locallyNote
Low Risk
Narrow Windows process-creation flag change for optional GUI spawn; no auth, mesh, or catalog changes. POSIX path is untouched.
Overview
Windows
--spawnforblockout-open-setupnow ORsCREATE_BREAKAWAY_FROM_JOBso GUI Blender is not killed when an agent shell’s Job Object closes (KILL_ON_JOB_CLOSE). Detached + new process group stay; POSIXstart_new_sessionis unchanged.Spawn failures still fail closed as
setup_spawn_failedwith no retry, and optionaldetails.winerroris attached when present. Tests pin the breakaway bit viagetattr(POSIX-safe) and a single Popen call.Reviewed by Cursor Bugbot for commit cffbd6f. Bugbot is set up for automated code reviews on this repo. Configure here.