fix(0133-TorsoCompareDerivedMetrics): refresh bury/pride after measured overlay - #135
Merged
Merged
Conversation
… y+ry Recompute breast_rear_vs_chest_front_m and chest_clav_pride_m after measured chest/breast Y overlay. Measured scap/mid past is center-class (y + ry) minus oval rear when ry is finite; missing ry leaves RECIPE past unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
breast_rear_vs_chest_front_m/chest_clav_pride_mafter measured chest/breast Y overlay (PR feat(0125-TorsoChestBackLandmarkSpecsCaptureCompare): torso landmark capture, compare, and placement consume #127 Bugbot Medium leftover).(y + ry) - oval_rearwhenry_mfinite; missing ry leaves RECIPE past unchanged (B6).breast_disconnected/chest_clav_pridefollow refreshed metrics.Honesty (N6)
TORSO_COMPARE_HONESTY / RECIPE_HONESTY — authoring QA only; green compare ≠ print success. No remake / no D7. MCP stay 53. Hold 0105/0090/0066/0074/0118.
Test plan
tests/test_proportion_torso_compare.pyT1–T5/T10/T11tests/test_proportion_torso_soft_consume.pyE1/E3/E5 regressionledgerful verify(ruff / format / basedpyright / pytest)Note
Low Risk
Authoring-QA metric math only; no auth, mesh, or print-path changes. Wrong past/bury would mis-flag form-read, but behavior is covered by new unit tests.
Overview
Fixes stale derived torso metrics: bury and pride are now computed after measured chest/breast surface Ys overlay RECIPE values, so form-read tokens (
breast_disconnected,chest_clav_pride) follow the photo, not leftover RECIPE geometry.Measured scap/mid-back Y is treated as center-class: rear past is
(y + ry) - oval_rearonly whenry_mis finite. Missingryno longer invents past from the center alone.Tests cover overlay refresh, recipe-only baselines, center+ry past, missing-ry, recipe=None, and form-read following refreshed metrics. MCP catalog stays at 53.
Reviewed by Cursor Bugbot for commit f86f72c. Bugbot is set up for automated code reviews on this repo. Configure here.