Related to Kameck - #2024
Open
aba4gamer wants to merge 6 commits into
Open
Conversation
Report for RMGK01 (fa77cd4 - 7ffdc37)📈 Matched code: 71.66% (+0.11%, +5780 bytes) ✅ 71 new matches
...and 41 more new matches 📈 10 improvements in unmatched items
|
ThatNintendoNerd
requested changes
Sep 7, 2026
ThatNintendoNerd
left a comment
ThatNintendoNerd
left a comment
Collaborator
There was a problem hiding this comment.
First pass of review comments.
ThatNintendoNerd
requested changes
Sep 8, 2026
ThatNintendoNerd
left a comment
ThatNintendoNerd
left a comment
Collaborator
There was a problem hiding this comment.
Please make an effort to employ the constants in your changes, not just add them in uncommented. Obviously, constants with not enough context clues can be left uncommented, but various timing ones are typically easy to insert.
| MR::createKameckBeamHolder(); | ||
| switch (mBeamType) { | ||
| case BeamType_None: | ||
| case 0: |
Collaborator
There was a problem hiding this comment.
Restore BeamType_None to your enumerated type and use it here (and anywhere else a mBeamType value of 0 is checked).
| #pragma once | ||
|
|
||
| #include "Game/LiveActor/LiveActor.hpp" | ||
| #include "Game/Enemy/Kameck.hpp" |
Collaborator
There was a problem hiding this comment.
Should be kept to LiveActor.hpp and forward declare necessary classes from Kameck.hpp instead.
| MR::blendQuatUpFront(&_A0, -mGravity, _B0, 0.04f, 0.2f); | ||
| _90->removeDeadActor(); | ||
| mAnimScaleController->updateNerve(); | ||
| MR::blendQuatUpFront(&_A0, -mGravity, _B0, ::sUpVecBlendRate, ::sFrontVecBlendRate); |
Collaborator
There was a problem hiding this comment.
_B0 could be named mFrontVec.
| // const f32 sDefaultActiveDistance = | ||
| const f32 sFrontVecBlendRate = 0.2f; | ||
| const f32 sUpVecBlendRate = 0.04f; | ||
| // const f32 sTurnPlayerLimit = |
Collaborator
There was a problem hiding this comment.
Seems like uses of 0.98f imply this constant.
| }; // namespace NrvKameckBeam | ||
|
|
||
| KameckBeam::KameckBeam(const char* pName) | ||
| : LiveActor(pName), mEventListener(nullptr), mKameckTurtle(), _A0(), _A4(0, 0, 1), mWandLocalPosition(0, 0, 0), mBeamKind(BeamType_FireBall1) { |
Collaborator
There was a problem hiding this comment.
mEventListener can be default-initialized accordingly with an empty pair of parentheses.
| easeInOut = 1.0f - MR::calcNerveEaseInOutRate(this, 200, 400); | ||
| } | ||
| MR::addVelocityMoveToDirection(this, _B0, 0.5f * easeInOut); | ||
| MR::rotateDirectionGravityDegree(this, &_A4, -25.0f * easeInOut); |
Collaborator
There was a problem hiding this comment.
::sRunSpinDegree?
| if (!isNerve(&NrvKameckTurtle::KameckTurtleNrvRun::sInstance)) { | ||
| return false; | ||
| } | ||
| if (MR::isLessStep(this, 300)) { |
Collaborator
There was a problem hiding this comment.
::sEnableAttackTime?
| if (!MR::normalizeOrZero(&dir)) { | ||
| _B0.set(dir); | ||
| } | ||
| MR::addVelocityJump(this, 15.0f); |
| MR::addVelocityToGravity(this, 0.7f); | ||
| } | ||
| f32 easeInOut = 1.0f; | ||
| if (MR::isGreaterStep(this, 200)) { |
Collaborator
There was a problem hiding this comment.
::sDeccelStartTime ?
| MR::startLevelSound(this, "SE_EM_LV_TURTLE_SLIDE"); | ||
| } | ||
| if (!MR::isBindedGround(this)) { | ||
| MR::addVelocityToGravity(this, 0.7f); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.