Hotfix/no bh kick stats - #14
Merged
Merged
Conversation
This commit fixes a few things to do with the stored `_kick_stats` in EvolvedMF when the kicks were not being computed normally. Most notably, before there was a bug when ejecting all BHs, because the kick stats were being written manually in EvolvedMF. Now, there is a new default "no kicks have been applied" constructor to the `KickStats` class, and the kicks are being computed (and then ignored) in the case when `BH_ret_dyn` is ejecting everything, so the stats can be stored. While this is technically less efficient, the kicks are quite fast and these stats are still interesting when ejecting all the rest of the BHs dynamically anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few things surrounding the stored
_kick_stats, especially when the natal kicks are either not applied at all, or when the overall ejections of BHs removes all of them (e.g.BH_ret_dyn=0).This is necessary to fix the bug found in GCfit at nmdickson/GCfit#222 (comment).