Feature/SEVN IFMR - #17
Merged
Merged
Conversation
When the compact remnant is entirely destroyed, the IFMR grids should denote this with the star type "15". This commit simply includes those lines (with a final mass of zero) rather than skipping them, which led to an incorrect linear interpolation.
Member
Author
|
I'll note that during these changes a much more major bug was found with the fallback fraction computations during the application of natal kicks, which will be fixed in another branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a couple new IFMR prescriptions using the SEVN models.
Also packaged with these IFMRs are corresponding fallback fraction curves which can be used to determine kicks.
Also fixes a bug in the IFMR interpolation which was found due to the PISN choices in the new IFMRs. Now, when the BHs are completely destroyed, leading to a startype of k=15, the mass will be interpolated as 0.