Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更摘要
修复桌面端的两个问题:
pnpm dev报错退出。Electron 问题通过升级传递依赖
yauzl并启用下载代理支持解决。会话问题通过调整生命周期持久化规则解决:没有任何 entry 的空会话不再写入 JSONL。关联 Issue
未关联 Issue。本次修复来自 Windows 桌面端的本地复现和诊断。
目标分支
dev。dev -> main(仅维护者)。main,并已说明如何同步回dev。实现说明
pnpm-workspace.yaml中将yauzl覆盖为^3.3.1,锁文件解析为3.4.0,修复旧版yauzl在 Node.js 26 下只解压 Electron ZIP 第一个文件的问题。ELECTRON_GET_USE_PROXY=true,使下载器使用现有的HTTP_PROXY、HTTPS_PROXY和NO_PROXY配置。AgentSession.new_session()和dispose()现在只会持久化包含 entry 的会话。创建后未使用的空会话会被丢弃,不再生成占位 JSONL。测试计划
uv run ruff check .uv run pyright --project pyrightconfig.release.jsonuv run pytest -quv build --all-packagesuv run python scripts/check_versions.pyuv run coding-agent --help补充验证:
pnpm dev:Vite 返回 HTTP 200,TypeScript watcher 为 0 errors,Electron 42.3.0 正常启动。pnpm --dir apps/desktop typecheck:通过。pnpm --dir apps/desktop build:通过。uv run pytest packages/app/tests/test_desktop_protocol.py -q:9 passed。uv run pyright packages/app/src/coding_agent/core/agent_session.py:0 errors。test_desktop_protocol.py和test_release_p0.py时有 13 passed、2 failed;失败来自两个既有测试在 Windows 上生成的 pytest 临时会话路径超过传统路径长度限制,与本次逻辑改动无关。提交前检查
CHANGELOG.md(适用时)。CONTRIBUTING.md。