Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/add_table_styling.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: minor
---

# Add table styling
20 changes: 20 additions & 0 deletions src/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,26 @@ pre {
font-variant-ligatures: contextual;
}

table {
border-collapse: collapse;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add horizontal scrolling or a width constraint for wide tables? They can overflow the message bubble on mobile.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be nice, yes!

}

table td,
table th {
padding: 5px;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a standard unit of padding that can be used here?

I've tried searching for some in the codebase but couldn't find anything.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.space.S{0 to 500}

border: 1px solid var(--sable-surface-container-line);
}

table th {
background-color: var(--sable-surface-var-container);
color: var(--sable-surface-var-on-container);
}

table td {
background-color: var(--sable-surface-container);
color: var(--sable-surface-on-container);
}

/* Accessibility Overrides :D */

.force-underline-links [data-message-id] a:not([data-mention-id]),
Expand Down
Loading