-
Notifications
You must be signed in to change notification settings - Fork 78
feat: Add table styling #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat: Add table styling #1580
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| default: minor | ||
| --- | ||
|
|
||
| # Add table styling |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,6 +148,26 @@ pre { | |
| font-variant-ligatures: contextual; | ||
| } | ||
|
|
||
| table { | ||
| border-collapse: collapse; | ||
| } | ||
|
|
||
| table td, | ||
| table th { | ||
| padding: 5px; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a standard unit of padding that can be used here? I've tried searching for some in the codebase but couldn't find anything.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. config.space.S{0 to 500} |
||
| border: 1px solid var(--sable-surface-container-line); | ||
| } | ||
|
|
||
| table th { | ||
| background-color: var(--sable-surface-var-container); | ||
| color: var(--sable-surface-var-on-container); | ||
| } | ||
|
|
||
| table td { | ||
| background-color: var(--sable-surface-container); | ||
| color: var(--sable-surface-on-container); | ||
| } | ||
|
|
||
| /* Accessibility Overrides :D */ | ||
|
|
||
| .force-underline-links [data-message-id] a:not([data-mention-id]), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add horizontal scrolling or a width constraint for wide tables? They can overflow the message bubble on mobile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could be nice, yes!