fix(auth): carry the homeserver in the query string instead of the path - #1582
Open
eleboucher wants to merge 1 commit into
Open
fix(auth): carry the homeserver in the query string instead of the path#1582eleboucher wants to merge 1 commit into
eleboucher wants to merge 1 commit into
Conversation
eleboucher
force-pushed
the
fix/auth-homeserver-query-param
branch
from
August 2, 2026 09:18
8be4234 to
5b5f325
Compare
eleboucher
force-pushed
the
fix/auth-homeserver-query-param
branch
from
August 2, 2026 18:03
5b5f325 to
25ee7b9
Compare
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-1582-sable.raspy-dream-bb1d.workers.dev | 25ee7b9 | pr-1582 |
Sun, 02 Aug 2026 18:05:04 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A homeserver typed as a full URL landed in the path as
/login/http%3A%2F%2Fhost, and the hosting 307-redirects%2Fto a real slash, the mangled URL then matched a room route, so after login you ended up in a fake room named "login".The homeserver now rides in the query string (
/login?server=...), old/login/<server>links (incl. SSO/OIDC callbacks) redirect to it, and auth paths are never kept as an after-login destination.Fixes #
Type of change
Checklist:
AI disclosure: