Skip to content

Removing unintended change#703

Merged
preetkaran20 merged 37 commits into
masterfrom
karan/pass_reset
Jul 19, 2026
Merged

Removing unintended change#703
preetkaran20 merged 37 commits into
masterfrom
karan/pass_reset

Conversation

@preetkaran20

@preetkaran20 preetkaran20 commented Jul 19, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Removed URL and hash-based vulnerability selection to prevent unintended deep-link navigation.
    • Preserved automatic vulnerability selection and existing help and mode toggle interactions.

wipheg and others added 30 commits June 12, 2026 10:26
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Log a warning when mail server is unavailable instead of throwing an exception.
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4a30e933-52e6-49bb-93b9-8b5fbf2157de

📥 Commits

Reviewing files that changed from the base of the PR and between 26f53e9 and da80c03.

📒 Files selected for processing (1)
  • src/main/resources/static/vulnerableApp.js
💤 Files with no reviewable changes (1)
  • src/main/resources/static/vulnerableApp.js

📝 Walkthrough

Walkthrough

The vulnerable application update flow no longer applies URL or hash-based vulnerability and level selection. The deep-link helper and its invocation were removed, while help and mode event listener registration remains.

Changes

Deep-link selection removal

Layer / File(s) Summary
Remove deep-link preselection
src/main/resources/static/vulnerableApp.js
update(...) no longer invokes _applyDeepLinkSelection(...), and the helper that parsed URL state and triggered vulnerability or level selections was removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too vague to describe the actual code removal in vulnerableApp.js. Use a specific title like 'Remove deep-link selection from vulnerableApp.js'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch karan/pass_reset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@preetkaran20
preetkaran20 merged commit 94c9157 into master Jul 19, 2026
2 checks passed
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.08%. Comparing base (26f53e9) to head (da80c03).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #703   +/-   ##
=========================================
  Coverage     55.08%   55.08%           
  Complexity      751      751           
=========================================
  Files           105      105           
  Lines          4206     4206           
  Branches        450      450           
=========================================
  Hits           2317     2317           
  Misses         1685     1685           
  Partials        204      204           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants