fix(cli): detach Windows daemon from parent Job Object - #129
Open
ao-kamal wants to merge 1 commit into
Open
Conversation
Agent harnesses (Claude Code, Grok Build) put the CLI in a Job Object with KILL_ON_JOB_CLOSE. When the command ends, the daemon and every managed Chromium die, so named-page login state vanishes even though profiles stay on disk. Unix already called setsid(). Windows now requests CREATE_BREAKAWAY_FROM_JOB (plus a detached new process group). If breakaway is denied (Access Denied / error 5), spawn via WMI Win32_Process.Create so WmiPrvSE is the parent and the daemon survives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows,
spawn_daemoncurrentlyCommand::spawnsnodeas a child of the CLI process. Agent harnesses (Claude Code, Grok Build) wrap that CLI in a Job Object withKILL_ON_JOB_CLOSE. When the tool command ends, Windows kills the daemon and every managed Chromium. Named-page login cookies stay on disk under~/.dev-browser/browsers/, but the window is gone.Unix already called
setsid(). This PR does the Windows equivalent:CREATE_BREAKAWAY_FROM_JOB | CREATE_NEW_PROCESS_GROUP | DETACHED_PROCESS | CREATE_NO_WINDOWERROR_ACCESS_DENIED/ 5) — some harness jobs omitJOB_OBJECT_LIMIT_BREAKAWAY_OK— fall back to WMIWin32_Process.Createso the parent isWmiPrvSE, outside the job.Idle-timeout (
#124) is unrelated and already on main. This is only daemon lifetime.Test plan
cargo test quote_windows(quoting helper)dev-browser statustwice — same daemon pid / growing uptime--connect/ idle-timeout behavior unchanged