Skip to content

task(deps): update go-scalingo to remove support for the db-api - #1248

Closed
matthieu526-scalingo wants to merge 2 commits into
masterfrom
task/1247/remove-db-api
Closed

task(deps): update go-scalingo to remove support for the db-api#1248
matthieu526-scalingo wants to merge 2 commits into
masterfrom
task/1247/remove-db-api

Conversation

@matthieu526-scalingo

@matthieu526-scalingo matthieu526-scalingo commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

The DB API has been deprovisionned and is not required anymore.
This is pending confirmation from UFS here.

Based on this go-scalingo PR.

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md
  • Update go-scalingo to the new released version

Fix #1247 .

@matthieu526-scalingo matthieu526-scalingo self-assigned this Aug 10, 2026
@matthieu526-scalingo
matthieu526-scalingo requested a review from a team as a code owner August 10, 2026 13:57
@matthieu526-scalingo
matthieu526-scalingo requested review from sc-david-voisin and removed request for a team August 10, 2026 13:57

@sc-david-voisin sc-david-voisin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, one question though

Comment thread cmd/firewall_rules.go
Examples: []string{
"scalingo database-firewall-managed-ranges my-db-id",
"scalingo --database my-db database-firewall-managed-ranges",
"scalingo database-firewall-managed-ranges",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: good catch, they are not linked to a database

Comment thread go.mod
require (
github.com/AlecAivazis/survey/v2 v2.3.7
github.com/Scalingo/go-scalingo/v11 v11.1.1
github.com/Scalingo/go-scalingo/v11 v11.1.2-0.20260810110303-774d8583f620

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: the incoming go-scalingo CHANGELOG indicated "breaking change", so I suppose this version is not the definitive one ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's exactly why I put Update go-scalingo to the new released version in the description 🙂
In any case I'll be waiting on UFS before going further.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I misunderstood its meaning.
And if you wait for UFS, it is all good!

@matthieu526-scalingo

Copy link
Copy Markdown
Contributor Author

Closing this for now. The behaviour is not the one expected. The switch of endpoint comes with a side effect, where the "prefix" are different. IE /v1 vs /api. It would require keeping both clients, or refactor in a more complex way. This is not worth it for now as this is a temporary situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for internal db-api

2 participants