Recognize explicit second-order AD inside AutoSparse - #1288
Closed
ChrisRackauckas-Claude wants to merge 2 commits into
Closed
Recognize explicit second-order AD inside AutoSparse#1288ChrisRackauckas-Claude wants to merge 2 commits into
ChrisRackauckas-Claude wants to merge 2 commits into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Investigation scratchpad:
|
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Follow-up commit |
Member
Author
|
Final-head local validation after the OptimizationBase v5.2.5 bump: |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Problem
OptimizationCachewarns that second-order AD is missing when an optimizer requires Hessians even if the user explicitly suppliedAutoSparse(SecondOrder(...)). The sparse differentiation path already understands and preserves this representation, so the warning is incorrect.This became visible in the BoundaryValueDiffEqMIRK downgrade lane after OptimizationIpopt 1.3 moved to the shared
OptimizationCache.Change
AutoSparse{<:SecondOrder}as explicit second-order AD.AutoSparse(AutoForwardDiff())still emitsmissing_second_order_ad.Local verification
GROUP=OptimizationBase julia +1.10 --project=. -e 'using Pkg; Pkg.test()'Core | 54 passed / 54 totalOptimizationBase tests passed--check .passed.