Skip to content

this is sehar assignment - #1

Open
SeharShakir wants to merge 6 commits into
mainfrom
assignment
Open

this is sehar assignment#1
SeharShakir wants to merge 6 commits into
mainfrom
assignment

Conversation

@SeharShakir

@SeharShakir SeharShakir commented Jul 27, 2026

Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@Dmytro-Bonislavskyi Dmytro-Bonislavskyi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SeharShakir There are still some issues that need to be addressed:

Image

@Dmytro-Bonislavskyi

Copy link
Copy Markdown

mv rawdata/* data/raw/
it moves only the contents of rawdata, not the rawdata directory itself.

Try just:
mv rawdata data/raw

@SeharShakir

Copy link
Copy Markdown
Owner Author

Thank you for your comments. Just to know if I am going in the right direction. Now I should update my codes and follow the rest of the procedure with git add, commit, push and then pull request

@Dmytro-Bonislavskyi Dmytro-Bonislavskyi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants