feat: make --library-name optional, fallback to solution name by vystartasv · Pull Request #260 · SharePoint/spfx

vystartasv · 2026-07-11T14:09:00Z

Description

Makes --library-name optional on spfx create. When omitted, the solution name is used as the default library name instead of requiring explicit input.

Closes #246

How was this tested?

Change is scoped to CreateAction.ts only — parameter type changed from required to optional, fallback uses computed solutionName
Verified the fallback path handles both missing --library-name and missing --solution-name
Branch rebuilt off main to remove earlier cross-PR contamination — only this feature's changes are included

Type of change

Bug fix
New feature / enhancement
Template change
Documentation / CI / governance

Copilot

Pull request overview

This PR updates the SPFx CLI to reduce required inputs when scaffolding a component and also modifies list-templates output behavior around --spfx-version.

Changes:

Makes create --library-name optional and attempts to default it when omitted.
Adds --spfx-version template filtering behavior (in addition to existing branch selection behavior) to list-templates.
Updates list-templates help text to describe the filtering behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
apps/spfx-cli/src/cli/actions/CreateAction.ts	Makes `--library-name` optional and introduces fallback behavior.
apps/spfx-cli/src/cli/actions/ListTemplatesAction.ts	Adds `--spfx-version` filtering logic and updates command documentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Adam-it · 2026-07-13T07:51:41Z

@vystartasv seems like this PR has commits from #259 PR ☹️
please check my comment in
#261 (comment)

vystartasv · 2026-07-13T13:19:17Z

@Adam-it Thanks for the feedback about mixed commits from #259 — I've rebased the branch cleanly so it only contains the #260-specific changes now (library-name optional + the SPFxTemplateCollection import fix). No more cross-PR commits.

Also — you're right about the AI-generated code concern. Going forward I'll review everything more carefully before opening PRs. Appreciate you flagging it.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Fixes two issues: 1. Reverts --library-name back to optional (regression from merge conflict with already-merged PR SharePoint#260 that made it optional on main) 2. Fixes example text to accurately describe CLI behavior: - Subfolder output, not CWD - Use --package-manager none (not pnpm) to skip install - Include required params in all examples now that --library-name is optional, examples show the minimal arguments needed Co-Authored-By: Claw <claw@hermes>

Copilot AI review requested due to automatic review settings July 11, 2026 14:09

Copilot started reviewing on behalf of vystartasv July 11, 2026 14:10 View session

Copilot AI reviewed Jul 11, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 11, 2026 21:19

Copilot started reviewing on behalf of vystartasv July 11, 2026 21:20 View session

Copilot AI reviewed Jul 11, 2026

View reviewed changes

Comment thread apps/spfx-cli/src/cli/actions/ListTemplatesAction.ts Outdated

Comment thread apps/spfx-cli/src/cli/actions/ListTemplatesAction.ts Outdated

Comment thread apps/spfx-cli/src/cli/actions/CreateAction.ts

Comment thread apps/spfx-cli/src/cli/actions/CreateAction.ts

vystartasv force-pushed the fix/246-library-name-optional branch from dda19b5 to eb968a8 Compare July 13, 2026 13:18

Copilot AI review requested due to automatic review settings July 13, 2026 13:18

This was referenced Jul 13, 2026

feat: add usage examples to CLI help output #262

Closed

fix(list-templates): treat --spfx-version as output filter instead of branch selector #259

Open

Copilot started reviewing on behalf of vystartasv July 13, 2026 13:19 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread apps/spfx-cli/src/cli/actions/ListTemplatesAction.ts Outdated

Comment thread apps/spfx-cli/src/cli/actions/ListTemplatesAction.ts Outdated

Comment thread apps/spfx-cli/src/cli/actions/CreateAction.ts

Comment thread apps/spfx-cli/src/cli/actions/CreateAction.ts

feat: make --library-name optional, fallback to solution name

0304b44

Copilot AI review requested due to automatic review settings July 13, 2026 14:33

vystartasv force-pushed the fix/246-library-name-optional branch from eb968a8 to 0304b44 Compare July 13, 2026 14:33

Copilot started reviewing on behalf of vystartasv July 13, 2026 14:37 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread apps/spfx-cli/src/cli/actions/CreateAction.ts

Comment thread apps/spfx-cli/src/cli/actions/CreateAction.ts

vystartasv added a commit to vystartasv/spfx that referenced this pull request Jul 13, 2026

chore: remove change file that belongs to PR SharePoint#260

203d387

chore: add change file for --library-name optional

cc528cf

Copilot AI review requested due to automatic review settings July 13, 2026 14:49

Copilot started reviewing on behalf of vystartasv July 13, 2026 14:51 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread apps/spfx-cli/src/cli/actions/CreateAction.ts

Comment thread apps/spfx-cli/src/cli/actions/CreateAction.ts

Comment thread apps/spfx-cli/src/cli/actions/CreateAction.ts

Comment thread common/changes/@microsoft/spfx-cli/library-name-optional_2026-07-13.json

iclanton previously approved these changes Jul 13, 2026

View reviewed changes

iclanton enabled auto-merge (squash) July 13, 2026 18:49

Copilot AI mentioned this pull request Jul 15, 2026

Update spfx create help snapshot for optional --library-name #263

Closed

test: update create help snapshot

010d48e

Copilot AI review requested due to automatic review settings July 15, 2026 21:30

iclanton dismissed their stale review via 010d48e July 15, 2026 21:30

Copilot started reviewing on behalf of iclanton July 15, 2026 21:30 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread apps/spfx-cli/src/cli/actions/CreateAction.ts

nick-pape approved these changes Jul 16, 2026

View reviewed changes

iclanton merged commit b5806b4 into SharePoint:main Jul 16, 2026
4 checks passed

Uh oh!

Conversation

vystartasv commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How was this tested?

Type of change

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Adam-it commented Jul 13, 2026

Uh oh!

vystartasv commented Jul 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vystartasv commented Jul 11, 2026 •

edited

Loading