Skip to content

chore: stop stat'ing assets whose sizes nothing reads #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anurag6569201 wants to merge 1 commit into
base: qa/agent-sveltejs-kit/pr-08-16996/base
Choose a base branch
from
Open

chore: stop stat'ing assets whose sizes nothing reads #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/kit/src/core/adapt/builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,7 @@ export function create_builder({
route_data.filter((route) => prerender_map.get(route.id) !== true),
vite_config.root
);
/** @type {Record<string, number>} */
const files = {};
for (const file of server_assets) {
files[file] = statSync(path.resolve(build_data.out_dir, 'server', file)).size;

const ext = path.extname(file);
mime_types[ext] ??= mime_lookup(ext) || '';
}
Expand Down
1 change: 0 additions & 1 deletion packages/kit/src/core/sync/create_manifest_data/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export function create_assets(config) {

return [...walk(config.files.assets)].map((file) => ({
file,
size: fs.statSync(path.resolve(config.files.assets, file)).size,
type: lookup(file) || null
}));
}
Expand Down
2 changes: 0 additions & 2 deletions packages/kit/src/core/sync/create_manifest_data/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,12 +731,10 @@ test('lists static assets', () => {
expect(assets).toEqual([
{
file: 'bar/baz.txt',
size: 14,
type: 'text/plain'
},
{
file: 'foo.txt',
size: 9,
type: 'text/plain'
}
]);
Expand Down
1 change: 0 additions & 1 deletion packages/kit/src/types/internal.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ export interface ServerInternalModule {

export interface Asset {
file: string;
size: number;
type: string | null;
}

Expand Down