[Refactor] Modernize sleep function using node:timers/promises#8000
[Refactor] Modernize sleep function using node:timers/promises#8000gonzaloriestra wants to merge 1 commit into
Conversation
Modernize the `sleep` function in `packages/cli-kit/src/public/node/system.ts` to use the native `setTimeout` from `node:timers/promises` instead of a manual Promise wrapper. Also added a unit test to verify the behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
sleepfunction inpackages/cli-kit/src/public/node/system.tswas using an outdated manualPromisewrapper aroundsetTimeout. Modernizing it to usenode:timers/promisesmakes the code cleaner and leverages native Node.js capabilities.WHAT is this pull request doing?
setTimeoutfromtimers/promisesinpackages/cli-kit/src/public/node/system.ts.sleepto useawait setTimeout(...).sleepinpackages/cli-kit/src/public/node/system.test.ts.How to test your changes?
CI
Post-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 6335028973932666746 started by @gonzaloriestra