fix: prevent unhandled errors from superseded cart mutations - #3998
Open
fredericoo wants to merge 2 commits into
Open
fix: prevent unhandled errors from superseded cart mutations#3998fredericoo wants to merge 2 commits into
fredericoo wants to merge 2 commits into
Conversation
fredericoo
marked this pull request as ready for review
September 8, 2026 12:52
EvilGenius13
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Rapid cart updates deliberately abort superseded requests, but the correlated Standard Event promise was left unobserved and surfaced those cancellations as console errors.
Before
Repeatedly updating the same cart line produced an unhandled
AbortErrorfor every superseded request, even though the cart handled the cancellation correctly.After
Hydrogen observes the redundant correlated event promise while keeping the caller-facing action promise authoritative. Expected cancellations stay silent; genuine mutation failures still follow the existing error path.
What this changes
Developer impact
Includes a patch changeset for
@shopify/hydrogen. There are no public API or runtime contract changes.Out of scope
Risk
How to Test
pnpm --filter @shopify/hydrogen build.pnpm --filter @shopify/hydrogen-template-react-router dev.http://localhost:5173, add a product, and open the cart drawer.AbortErrormessages in the browser console.