Skip to content

Hide superseded Data Chat failure attempts - #250

Open
lfnandoo wants to merge 1 commit into
mainfrom
fix/data-chat-notebook-variable-conflicts
Open

Hide superseded Data Chat failure attempts#250
lfnandoo wants to merge 1 commit into
mainfrom
fix/data-chat-notebook-variable-conflicts

Conversation

@lfnandoo

@lfnandoo lfnandoo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • hide failed assistant messages once a later retry for the same user turn completes
  • keep the latest failed attempt visible when no retry succeeds
  • prevent successfully recovered notebook analyses from continuing to look failed in the conversation UI

Evidence

Conversation 5d5b4508-f55e-4948-8433-759161b4794f persisted two failed assistant messages for runs 599cd508-02ee-4917-a682-002d30071a1a and 1d3dd407-c1ae-4d43-b5fd-787ae69efb3b, followed by the completed retry 73e5aa23-b9c2-445c-b6ad-ce3c489ec9ff. The runtime was complete, but the UI rendered all three attempt outcomes.

Validation

  • standalone chat web state suite: 40 passed
  • TypeScript: pnpm exec tsc --noEmit passed
  • git diff --check passed

ESLint could not run because this checkout has ESLint 9 but no eslint.config.*; that existing tooling mismatch is unchanged by this PR.

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
signal-pilot Ready Ready Preview Aug 5, 2026 9:11pm
signal-pilot-docs Ready Ready Preview Aug 5, 2026 9:11pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant