Skip to content

[3.0] Load the guest data when verification demotes a member to one #9490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertlast wants to merge 1 commit into
base: release-3.0
Choose a base branch
from
Open

[3.0] Load the guest data when verification demotes a member to one #9490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Sources/User.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2914,6 +2914,16 @@ public static function loadMe(): self
self::$me->verifyPassword();
self::$me->verifyTfa();

/*
* Either of those can decide this is a guest after all, and the
* guest's data has not been loaded: the call above asked only for
* the member they claimed to be. Everything below here reads
* self::$profiles[0], so load it now that we know we need it.
*/
if (empty(self::$my_id) && !isset(self::$profiles[0])) {
self::loadUserData([0], self::LOAD_BY_ID, UserDataset::Minimal);
}

// At this point, we know the user ID for sure.
self::$me->id = self::$my_id;
self::$cookie_id = self::$my_id;
Expand Down