Skip to content

Add org.commcare.dalvik.echisethiopia.* permission declarations - #1838

Open
BurningAXE wants to merge 1 commit into
release/2026.3.0from
echis-commcare-permissions
Open

BurningAXE wants to merge 1 commit into
release/2026.3.0from
echis-commcare-permissions

Conversation

@BurningAXE

Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 2026.3.0

Root cause analysis (for bugfixes only)

First known affected version: all

  • The fork of CommCare that eCHIS uses has changed its package name and along with it - its permission name
  • Permissions are dynamically formed based on the calling package name. However, any permission that may be dynamically requested and used must be statically declared in the manifest
  • This was not done when the package name of eCHIS/CommCare fork was changed

Notable changes

  • Closes the gap by adding the new permission name (and its debug variant)

Testing guidance

  • Test with new CommCare fork and make sure SID can read from it when CommCare is set as data source

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot Bot added the ... label Sep 25, 2026
@BurningAXE BurningAXE changed the title Add org.commcare.dalvik.echisethiopia.* permission declarations so SI… Add org.commcare.dalvik.echisethiopia.* permission declarations Sep 25, 2026
@BurningAXE
BurningAXE requested a lite review from Copilot September 25, 2026 11:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approved

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Adds production and debug CommCare read-permission declarations for the eCHIS Ethiopia package variant, enabling SID access to the renamed CommCare fork.

Changes:

  • Adds eCHIS Ethiopia permissions to event synchronization.
  • Adds the same permissions to enrolment-record access.
File Description
infra/​event-sync/​src/​main/​AndroidManifest.xml Declares eCHIS Ethiopia provider permissions.
infra/​enrolment-records/​repository/​src/​main/​AndroidManifest.xml Declares eCHIS Ethiopia provider permissions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants