Validate runtime indexes before archive manifest assertion - #4589
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sinity
force-pushed
the
feature/packet/polylogue-3af3o
branch
from
September 3, 2026 17:59
46b5ff5 to
98addd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make CorpusArtifactManifest the sole manifest type for deterministic workload artifacts and remove the retired SeededArchiveManifest compatibility alias. The existing shared WorkloadEnvelopeSpec and WorkloadReceipt contract remains the common carrier for workload identity, phase observations, physical budgets, canaries, and explicit measurement-path dispositions.
Problem
The artifact substrate still exposed a second manifest name after CorpusArtifactManifest became canonical. That preserved a duplicate route and allowed callers to continue depending on the retired name. The packet also requires honest measurement-unavailable handling and anti-vacuity coverage across the shared receipt paths.
Solution
Update manifest readers, validators, builders, clone authentication, garbage-collection helpers, exports, and documentation strings to use CorpusArtifactManifest directly. No semantic expected result is carried by the manifest. The shared receipt implementation and named MCP exact-session and watcher append/cohort canaries are retained and exercised by the focused tests.
Verification
uv run devtools test tests/unit/scenarios/test_workload_receipts.py tests/unit/infra/test_workload_artifacts.pypassed: 99 passed in 1109.24s.uv run devtools test tests/unit/devtools -k workloadpassed: 3 passed, 960 deselected, 1 warning in 39.70s.uv run devtools test tests/unit -k enveloperan 391 tests: 385 passed, 5 failed, and 1 error. The failures are inherited fixture/schema or generated-web-content issues outside this diff: query execution fixture tool-outcome evidence, deployment smoke schema version, coordination archive fixtures, and selection-shell asset text.uv run devtools verify --quickpassed after rebasing onto origin/master. All 17 gates reported ok, including oracle-integrity, consumer-reachability, and schema promotion/privacy checks.Residual risk
The broad envelope selector retains six unrelated inherited failures. This lane does not claim live MCP or daemon incident measurements; those remain host-dependent observations. The implementation still has a hand-maintained measurement-path declaration inventory rather than kernel-derived declarations.
Receipt: harvest-191bc8cc410c6bee904ac799c7e8a9fc
Bead: polylogue-3af3o
Authorized-By: operator (operator batch 2026-09-02: merge finished lanes, verify once by corpus)