Claude/deposit vault screen redesign qa - #2525
Merged
Merged
Conversation
Every savings entry point — the header and mobile Deposit buttons, the empty state, the funded action row, Start earning and the home balances dropdown — opened "Deposit to savings" first: a token list whose only route to the amount form was the "Move from wallet" row buried under it. Point them straight at the form with depositFromSolid set, so the first screen is the one that takes an amount. The form already knows how to say there is nothing to deposit, but it read an unloaded balance as an empty one. As a step behind the token list that flashed by; as the entry point it would greet most users with the empty state before their balance arrived. Hold the decision until balances have loaded. The card's minimum-deposit step still opens the token list: it funds savings by sending new money in, which the form does not do. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The Destination dropdown is the only thing that reads `vaultName`, so "USDC / FUSE / ETH Savings" become "USD / FUSE / ETH Yield" to match the design. The deposit form had no back arrow because it had nowhere to go: as the savings entry point, back and close were the same action. Point it at the landing screen for the vault being deposited into instead, so it lands somewhere whether the flow was opened from that vault's own screen or from the home balances dropdown. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
"Add funds" opened the deposit-methods list; the screen it belongs on says the wallet holds nothing to deposit, so the wallet-funding entry is the step that follows. Clear depositFromSolid on the way out. Left set, the steps behind that screen still resolve to the vault deposit form rather than the add-funds-to-wallet one, and skip the wallet provider an external deposit needs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.