Restore accuracy truncation bound in 2.1.3 - #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accuracy: the relative first excluded singular valueSVEResult, as in the 1.x implementationmax_sizetruncation, and the no-excluded-value caseWhy
The current 2.x implementation returns the requested epsilon, rather than the achieved truncation bound. SparseIR.jl 1.x computed the bound from the first singular value excluded from the basis. This restores that behavior and aligns it with the Python fix in SpM-lab/sparse-ir#77.
Verification
max_size, and no-excluded-value casesgit diff --checkRelease ordering
The package remains compatible with the existing 0.8.x JLL and accepts the upcoming 0.9.x JLL. This patch can therefore be tested with the current registered artifact while latest-backend CI covers sparse-ir-rs main.