Require pylibsparseir 0.8.3 or newer - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pylibsparseir>=0.8.3minimum from chore: require pylibsparseir 0.8.3 #76<0.10.0upper bound added for pylibsparseir 0.9 compatibility in Restore accuracy truncation bound in 2.1.2 #77Why
PR #76 predates #77 and now conflicts with
mainline. Its minimum-version requirement is still relevant, but it should be applied on top of the 2.1.2 release changes instead of merging the stale branch directly.Validation
python3 check_libsparseir_version_consistency.py.venv/bin/python -m pytest tests/ -q97 passed, 8 skipped