Skip to content

Write scatter_indices bits without per-element capacity checks #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbower merged 3 commits into from
Oct 2, 2026
Merged

Write scatter_indices bits without per-element capacity checks #213

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fea8b61
Write scatter_indices bits without per-element capacity checks
pbower Oct 2, 2026
d24311b
Update array.rs
pbower Oct 2, 2026
a0adcbf
Update array.rs
pbower Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/enums/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,14 +1507,24 @@ impl Array {
match $src_mask {
Some(sm) => {
let mask = $dst_mask.get_or_insert_with(|| Bitmask::new_set_all(dst_len, true));
mask.ensure_capacity(dst_len);
for (&d, &s) in dst_idx.iter().zip(src_idx) {
mask.set(d, sm.get(offset + s));
// Safety:
// - the bounds checks above ensures every `d`
// is inside this array and every `s` inside the window
// - `ensure_capacity` sizes this mask to the array
// - the source mask spans its backing array.
unsafe { mask.set_unchecked(d, sm.get_unchecked(offset + s)) };
}
}
None => {
if let Some(mask) = $dst_mask.as_mut() {
mask.ensure_capacity(dst_len);
for &d in dst_idx {
mask.set(d, true);
// Safety:
// - the bounds check above ensures every `d` is inside this array
// - `ensure_capacity` sizes this mask to the array.
unsafe { mask.set_unchecked(d, true) };
}
}
}
Expand Down Expand Up @@ -1645,8 +1655,13 @@ impl Array {
},
(Array::BooleanArray(d), Array::BooleanArray(s)) => {
let dst = Arc::make_mut(d);
dst.data.ensure_capacity(dst_len);
for (&di, &si) in dst_idx.iter().zip(src_idx) {
dst.data.set(di, s.data.get(offset + si));
// Safety:
// - the bounds checks above mean every `di` is inside
// this array and every `si` inside the window
// - `ensure_capacity` sizes the value bits to the array.
unsafe { dst.data.set_unchecked(di, s.data.get_unchecked(offset + si)) };
}
scatter_mask!(dst.null_mask, s.null_mask.as_ref());
}
Expand Down
Loading