fix: Preserve Explore search icon color BED-9230

[justin-prime1]

Description

Prevents the node icon in a highlighted Explore search result from inheriting the row's white text color.

Sister BHE PR: https://github.com/SpecterOps/bloodhound-enterprise/pull/1727

BHCE PR: Blocked until https://github.com/SpecterOps/bloodhound-enterprise/pull/1727 is approved and ready to merge. This PR merges first, but both PRs must be fully ready before either merge begins.

Motivation and Context

In light mode, the internal user icon became white when its search result was highlighted, reducing its visibility.

Resolves BED-9230

How Has This Been Tested?

• Added regression coverage for a keyboard-highlighted search result.
• Verified the highlighted row uses white text while its icon remains dark and does not inherit the row color.
• Focused ExploreSearchCombobox suite: 7 passed.
• just prepare-for-codereview: passed.
• Manually verified in light and dark modes.
• Isolated Playwright Explore baseline passed with no page errors.

Screenshots (optional):

Validated in the task-owned local environment.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have met the contributing prerequisites
  • Assigned an issue
  • Associated the issue with the PR
  • Added appropriate labels
• I have ensured related documentation is up-to-date
• I have followed proper test practices

Blast Radius / Risk

Presentation-only change to the shared Explore search result component. No API, data, or interaction changes.

Test Changes

The existing combobox test now highlights the first result and verifies that its icon retains the dark glyph color.

Rollback

Revert the BHCE commit and restore the previous BHE submodule pointer.

Summary by CodeRabbit

• Bug Fixes
  • Improved keyboard selection styling in search results.
  • Ensured selected result icons maintain appropriate contrast without inheriting option text colors.
  • Refined hover, focus, and highlighted-state appearance for search result icons.

[coderabbitai]

📝 Walkthrough

Walkthrough

The search result icon no longer inherits hover, focus, or highlighted text colors. The combobox test now verifies selected-option styling and the selected option’s icon classes.

Changes

Search result styling

Layer / File(s)	Summary
Separate icon and option state colors packages/javascript/bh-shared-ui/src/components/SearchResultItem/SearchResultItem.tsx, packages/javascript/bh-shared-ui/src/components/ExploreSearchCombobox/ExploreSearchCombobox.test.tsx	NodeIcon no longer receives option-state color classes. The test verifies ArrowDown selection styling and the selected icon’s color classes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• SpecterOps/BloodHound#2966: Directly related through SearchResultItem.tsx and NodeIcon color-class inheritance.
• SpecterOps/BloodHound#3013: Overlaps in dropdown icon styling and selected-option text/icon colors.

Suggested labels: user interface, javascript

Suggested reviewers: holocraft, specter-flq

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the bug fix for the Explore search icon color and includes the associated ticket.
Description check	✅ Passed	The description covers the change, motivation, ticket, testing, change type, checklist, risk, and rollback details.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/explore-search-result-icon-color

---

_{Comment @coderabbitai help to get the list of available commands.}