Conversation
|
Focused exact-head review for
References:
Run-Id: |
8c9ba24 to
d0801e5
Compare
Fixes Applied for ReviewI have pushed a new commit to address all the feedback points raised during the review:
Tests are passing locally without warnings. Let me know if everything looks good now |
|
Response-driven exact-head review for The follow-up does close two prior blockers: it adds the missing
References:
Run-Id: |
|
Response-driven exact-head review for The follow-up closes the prior invalid-payload dispatch and atom-table findings: webhook/poller ingress now dispatches only validated
References:
Run-Id: |
Fixes Applied for Review (Commit 747f83c)I have pushed commit
Please let me know if any further adjustments are required. |
|
Response-driven review of The synchronous failure paths now propagate callback errors/raises/throws/exits; the poller stops at the first failed dispatch and retains the successfully processed prefix offset. The example now calls Two acceptance blockers remain:
Validation limit: this is a source-level follow-up across the 27-file change since the previous review, including the added tests and coverage configuration. Elixir is unavailable in this review environment, so I did not independently rerun the claimed 1,608 tests or 93.2% coverage. Current-head Lux CI is Run-Id: |
Closes #62
This PR introduces the complete Telegram Core API Integration as outlined in Bounty #62. The implementation provides a robust, production-ready foundation with extensive test coverage (>90%).
Key Deliverables:
Lux.Telegram.Clientwith secure token storage (usingInspectredaction) and Lens behavior integration.Lux.Telegram.PollerGenServer) for local dev, and Webhooks (Lux.Telegram.WebhookPlug) for production with secure token validation (Plug.Crypto.secure_compare/2).Lux.Telegram.Middleware.RateLimit) with automatic exponential backoff forHTTP 429 Retry-Afterevents and a robust retry pipeline.Verification:
Req.Testmocking (no live network required, verifying endpoints and payloads).mix compile --warnings-as-errors.Lux.Telegram.*modules.