Add testing of the sample profiling - #1684
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new integration tests under spynnaker_integration_tests/ to validate generation of the sample profiling report (and, in a second scenario, sample profiling alongside energy reporting), supporting coverage for SpiNNakerManchester/SpiNNFrontEndCommon#1374.
Changes:
- Add an integration test that runs a synfire model and asserts a sample profiling report JSON is produced and contains expected fields.
- Add an integration test that asserts both energy reporting (via provenance) and sample profiling report generation when both reports are enabled.
- Introduce per-test
spynnaker.cfgfiles to enable advanced monitor support and the required report outputs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spynnaker_integration_tests/test_sample_profile/test_sample_profile.py | New integration test that runs a model and validates sample profiling report JSON fields. |
| spynnaker_integration_tests/test_sample_profile/spynnaker.cfg | Enables sample profile report writing for the new test. |
| spynnaker_integration_tests/test_sample_profile/init.py | Marks the directory as a Python package for test discovery/imports. |
| spynnaker_integration_tests/test_sample_profile_and_power/test_sample_profile_and_energy.py | New integration test validating both energy provenance and sample profile report output. |
| spynnaker_integration_tests/test_sample_profile_and_power/spynnaker.cfg | Enables both energy and sample profiling reports for the combined test. |
| spynnaker_integration_tests/test_sample_profile_and_power/init.py | Marks the directory as a Python package for test discovery/imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| synfire_run = SynfireRunner() | ||
|
|
||
|
|
||
| class TestSampleProfilingWithEnerfy(BaseTestCase): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for SpiNNakerManchester/SpiNNFrontEndCommon#1374