fix(DSO-26757): bump js-yaml to 4.3.2 - #320
Merged
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
nurislam03
force-pushed
the
DSO-26757-bump-js-yaml
branch
3 times, most recently
from
September 13, 2026 16:37
83745fa to
f47f593
Compare
nurislam03
force-pushed
the
DSO-26757-bump-js-yaml
branch
from
September 13, 2026 16:48
f47f593 to
9887edd
Compare
|
🟢 Sucessfully merged into the dev branch. |
Staffbase AI Code ReviewVerdict: ✅ Approved
FindingsNo findings. Bot commands
You can also resolve a non-critical inline conversation to ignore it (and unresolve to bring it back). Resolving a To bypass the entire review (criticals included), apply the Execution Steps (3)
|
axdotl
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mitarbeiterapp.atlassian.net/browse/DSO-26757
Type of Change
Description
What: Bump
js-yamlresolutions pin from 4.3.0 to 4.3.2 insamples/weather-forecast(package.json + yarn.lock).Why: CVE-2026-84375 — empty-merge CPU DoS where
maxTotalMergeKeysfails for empty merges. Fixed in js-yaml 4.3.2. Lockfile confirmed resolving 4.3.0 (vulnerable) before this change.How to review: Check
git diff main— two files, resolutions pin + regenerated lockfile entry. Verify withyarn install --frozen-lockfile && yarn build && yarn testinsamples/weather-forecast. All green locally (build ok, lint ok, type-check ok, 19/19 tests pass).Checklist