Skip to content

fix(DSO-26757): bump js-yaml to 4.3.2 - #320

Merged
nurislam03 merged 1 commit into
mainfrom
DSO-26757-bump-js-yaml
Sep 14, 2026
Merged

nurislam03 merged 1 commit into
mainfrom
DSO-26757-bump-js-yaml

Conversation

@nurislam03

Copy link
Copy Markdown
Contributor

https://mitarbeiterapp.atlassian.net/browse/DSO-26757

Type of Change

  • Dependency

Description

What: Bump js-yaml resolutions pin from 4.3.0 to 4.3.2 in samples/weather-forecast (package.json + yarn.lock).

Why: CVE-2026-84375 — empty-merge CPU DoS where maxTotalMergeKeys fails for empty merges. Fixed in js-yaml 4.3.2. Lockfile confirmed resolving 4.3.0 (vulnerable) before this change.

How to review: Check git diff main — two files, resolutions pin + regenerated lockfile entry. Verify with yarn install --frozen-lockfile && yarn build && yarn test in samples/weather-forecast. All green locally (build ok, lint ok, type-check ok, 19/19 tests pass).

Checklist

@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@nurislam03
nurislam03 force-pushed the DSO-26757-bump-js-yaml branch 3 times, most recently from 83745fa to f47f593 Compare September 13, 2026 16:37
@nurislam03
nurislam03 force-pushed the DSO-26757-bump-js-yaml branch from f47f593 to 9887edd Compare September 13, 2026 16:48
@nurislam03 nurislam03 added the dev Pull Requests that deployed to dev label Sep 13, 2026
@staffbase-actions

Copy link
Copy Markdown

🟢 Sucessfully merged into the dev branch.
It can take up to a few minutes until the changes are rolled out to the dev system.
The following Pull Requests are merged into the dev branch:

@nurislam03
nurislam03 marked this pull request as ready for review September 14, 2026 07:17
@nurislam03
nurislam03 requested a review from a team as a code owner September 14, 2026 07:17
@review-swarm

review-swarm Bot commented Sep 14, 2026

Copy link
Copy Markdown

Staffbase AI Code Review

Verdict: ✅ Approved

Diff classified as trivial (≤10 lines, ≤5 files). No reviewers run.

📌 Only the first push is reviewed automatically. After that, comment @swarm review to re-review the latest commit.

  • Risk tier: trivial
  • Size: XS (trivial to review)
  • Head commit: 9887edd
  • Findings: 0 critical, 0 warning, 0 suggestions

Findings

No findings.


Bot commands
  • @swarm ignore <id> [<id>...] — dismiss one or more findings by id (space-separated, including criticals — review each one before dismissing).
  • @swarm ignore-all — dismiss every open warning/suggestion (criticals must be dismissed explicitly via ignore <id>).
  • @swarm reset-ignores — clear all dismissals on this PR.
  • @swarm review — re-run the review against the latest commit.

You can also resolve a non-critical inline conversation to ignore it (and unresolve to bring it back). Resolving a critical conversation is not supported — use ignore <id> instead.

To bypass the entire review (criticals included), apply the break-glass label to the PR.

Execution Steps (3)
  1. Filter Diff — ✅ completed
    • Files: 1, +1/-1 lines
  2. Reviewer Pipeline — ⏭️ skipped
    • Reason: trivial tier
  3. Judge Pass — ⏭️ skipped
    • Reason: trivial tier

@review-swarm review-swarm Bot added the size/XS Pull requests that are extra small and quick to review label Sep 14, 2026
@nurislam03
nurislam03 merged commit 0d49d8b into main Sep 14, 2026
12 checks passed
@nurislam03
nurislam03 deleted the DSO-26757-bump-js-yaml branch September 14, 2026 14:30
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dev Pull Requests that deployed to dev size/XS Pull requests that are extra small and quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants