fix(release): stop publishing broken .app.zip and updater artifacts - #11
Merged
Conversation
MarkDoc has no updater plugin, but the release pipeline was still uploading Tauri updater payloads (`*.app.tar.gz`, `*.sig`) and a separately-built `*.app.zip` that arrives on macOS with its signed resources stripped by `actions/upload-artifact@v4`'s zip round-trip — so any user grabbing the zip gets a bundle that fails to launch with "code has no resources but signature indicates they must be present". - Set `bundle.createUpdaterArtifacts: false` and enumerate targets explicitly (drops the updater target that `"all"` implies). - Remove the `attach-app-bundles` job and its upload-artifact steps. - Update CLAUDE.md release-pipeline description. Closes #10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10 — the
MarkDoc_aarch64.app.zipon the v0.1.6 release looked installable but launched withRBSRequestErrorDomain Code=5 "Launch failed."becausecodesignreported the bundle's sealed resources were missing.Two independent issues in the release pipeline were producing junk assets on every release:
.app.tar.gz+.sig— Tauri updater payloads. MarkDoc has no updater plugin (notauri-plugin-updater, noplugins.updaterconfig), so these are useless to end users but were still being generated bybundle.targets: "all"and uploaded bytauri-action..app.zip— created by theattach-app-bundlesjob, which usedactions/upload-artifact@v4to move the signed.appfrom the macOS runner to a Linux runner and re-zip it. That round-trip drops the extended attributes and resources that the code signature seals, producing the "code has no resources but signature indicates they must be present" state the reporter observed.The DMGs are fine and remain the macOS install path.
Changes
src-tauri/tauri.conf.json: enumeratebundle.targetsexplicitly (noupdater) and setbundle.createUpdaterArtifacts: false..github/workflows/release.yml: remove the twoUpload macOS .app Bundlesteps and the entireattach-app-bundlesjob.CLAUDE.md: update the release-workflow description; note which assets are published and why the updater payloads are suppressed.Assets after this change
Just the installers users actually need:
MarkDoc_<v>_aarch64.dmg,MarkDoc_<v>_x64.dmgMarkDoc_<v>_x64_en-US.msi,MarkDoc_<v>_x64-setup.exeMarkDoc_<v>_amd64.deb,MarkDoc-<v>-1.x86_64.rpm,MarkDoc_<v>_amd64.AppImageTest plan
cargo check --locked— validatestauri.conf.jsonschema (newcreateUpdaterArtifactsfield, enumerated targets)patchrelease viaCreate Releaseworkflow and confirm the release page contains only the seven installer assets aboveaarch64.dmg, install, and launch on Apple Silicon.app.zip/.app.tar.gzfiles are still on the v0.1.6 release page. Should be deleted separately after merge.