Fixed bullet trajectories when firing from a vehicle. - #358
Draft
Vitroze wants to merge 4 commits into
Draft
Conversation
Owner
|
To be honest I worry that the "override PlayerMeta functions" approach conflicts with other addons doing the same (like seat weaponizer), besides being a thing that saps a little performance for being called in so many places in the game |
Contributor
Author
|
I agree, but I don't see how to make all projectiles and bullet trajectories compatible without overwriting those functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In connection with this PR and this comment (#357 (comment)), I have created a separate PR.
It is a workaround that works in itself.
However, it does not work with standard Garry's Mod projectiles:
I'm saving this PR as a draft. If anyone wants to work on this or if you want to go ahead and push it now, feel free to do so. This PR won't be my priority, but I'll try to work on it as soon as I have some free time.