fix: run schema validation on solution builds and disable plugin auto-pack - #100
Open
zekelinAlex wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the existing ValidateSolutionComponentSchema target into the solution build (after ProcessCds, before packaging), so component XML/JSON gets schema-checked on every build instead of only when invoked by hand. Opt out with SkipSchemaValidation=true.
Also fixes a regression from #96: Microsoft.PowerApps.MSBuild.Plugin.props defaults GeneratePackageOnBuild to true, so Pack ran after every plugin/workflow activity build and hit the new "cannot be packed" guard. Those project types now set GeneratePackageOnBuild=false; explicit dotnet pack still errors as intended.