fix: fail build when packed solution is missing root components - #102
Open
zekelinAlex wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packager only warns when Solution.xml declares root components that have no
source files, so the build stayed green and packed an incomplete zip. That's
how the missing SdkMessageProcessingSteps from #47 slipped through to import.
InvokeSolutionPackager now checks the SolutionPackagerResult from
Metadata.Packaging: packager errors and missing root components become MSBuild
errors and the incomplete zip gets deleted so nothing downstream picks it up.
Other packager warnings now surface as MSBuild warnings instead of vanishing.
Depends on TALXIS.Platform.Metadata.Packaging with SolutionPackagerResult
(TALXIS/platform-metadata#73); bump the package pin here once it's published.
Closes #47.