Skip to content

HTM-1986: Add new endpoints to support directly attaching a new GeoService or TMFeatureSource to a catalog node - #1909

Merged
matthijsln merged 7 commits into
mainfrom
HTM-1986_parent_id_when_adding_service
Sep 22, 2026
Merged

matthijsln merged 7 commits into
mainfrom
HTM-1986_parent_id_when_adding_service

Conversation

@mprins

@mprins mprins commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

HTM-1986 Powered by Pull Request Badge

@mprins mprins self-assigned this Sep 17, 2026
@mprins mprins added enhancement New feature or request refactoring labels Sep 17, 2026
@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 15a6fec.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@mprins
mprins force-pushed the HTM-1986_parent_id_when_adding_service branch from 55cf8fe to beb4e6b Compare September 17, 2026 13:43
@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.25806% with 22 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../api/persistence/helper/TMFeatureSourceHelper.java 58% 5 Missing and 4 partials ⚠️
...controller/admin/FeatureSourceAdminController.java 80% 6 Missing and 1 partial ⚠️
...pi/controller/admin/GeoServiceAdminController.java 92% 3 Missing and 1 partial ⚠️
...ormap/api/persistence/helper/GeoServiceHelper.java 80% 2 Missing ⚠️

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #1909   +/-   ##
======================================
+ Coverage      77%     77%   +1%     
- Complexity    171     185   +14     
======================================
  Files         173     172    -1     
  Lines        8660    8666    +6     
  Branches      808     804    -4     
======================================
+ Hits         6588    6640   +52     
+ Misses       1593    1546   -47     
- Partials      479     480    +1     
Files with missing lines Coverage Δ Complexity Δ
...lormap/api/configuration/dev/PopulateTestData.java 93% <100%> (+1%) 0 <0> (ø)
...i/geotools/featuresources/FeatureSourceHelper.java 86% <100%> (ø) 0 <0> (ø)
...java/org/tailormap/api/persistence/GeoService.java 83% <ø> (-<1%) 8 <0> (ø)
...org/tailormap/api/persistence/TMFeatureSource.java 81% <100%> (+3%) 9 <0> (+9)
...repository/validation/ValidationConfiguration.java 100% <ø> (ø) 0 <0> (ø)
...ormap/api/persistence/helper/GeoServiceHelper.java 85% <80%> (-<1%) 1 <0> (ø)
...pi/controller/admin/GeoServiceAdminController.java 93% <92%> (-3%) 0 <0> (ø)
...controller/admin/FeatureSourceAdminController.java 86% <80%> (-14%) 0 <0> (ø)
.../api/persistence/helper/TMFeatureSourceHelper.java 58% <58%> (ø) 5 <5> (?)

... and 5 files with indirect coverage changes

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Test Results

679 tests   677 ✅  10m 48s ⏱️
 66 suites    2 💤
 66 files      0 ❌

Results for commit 15a6fec.

♻️ This comment has been updated with latest results.

@mprins
mprins force-pushed the HTM-1986_parent_id_when_adding_service branch from beb4e6b to 00ead3e Compare September 17, 2026 14:07
@mprins
mprins force-pushed the HTM-1986_parent_id_when_adding_service branch 4 times, most recently from 44ea13a to 6435736 Compare September 18, 2026 15:35
@mprins mprins changed the title HTM-1986: Add a new endpoint to support directly attaching a new GeoService to a catalog node HTM-1986: Add new endpoints to support directly attaching a new GeoService or TMFeatureSource to a catalog node Sep 18, 2026
@mprins
mprins force-pushed the HTM-1986_parent_id_when_adding_service branch 3 times, most recently from 13d1fea to 4511ddd Compare September 21, 2026 13:27
@mprins
mprins force-pushed the HTM-1986_parent_id_when_adding_service branch 2 times, most recently from 7110522 to b7f7e7f Compare September 21, 2026 13:28
@mprins
mprins marked this pull request as ready for review September 21, 2026 13:55
@mprins
mprins requested review from a team and a lite review from Copilot September 21, 2026 13:55

This comment was marked as resolved.

…he chance of an ObjectOptimisticLockingFailureException occurring
@mprins
mprins force-pushed the HTM-1986_parent_id_when_adding_service branch from b7f7e7f to f5cbf31 Compare September 21, 2026 14:34
@matthijsln
matthijsln merged commit 1c7bb36 into main Sep 22, 2026
23 checks passed
@matthijsln
matthijsln deleted the HTM-1986_parent_id_when_adding_service branch September 22, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants