온보딩 Domain User 계약 추가 - #16
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
📝 SummarySummary by CodeRabbit
WalkthroughAuth 세션 계약과 의존성 클라이언트를 추가했습니다. User 모델, 오류 타입, 온보딩 클라이언트를 추가했습니다. 모델의 동등성 및 Codable 동작과 테스트 의존성 기본값을 검증했습니다. ChangesDomain 포트 확장
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Projects/Domain/Tests/User/UserClientTests.swift`:
- Around line 5-9: The test contract is inconsistent with the documented
behavior: update Projects/Domain/Tests/User/UserClientTests.swift lines 5-9 by
renaming the Korean test to clearly describe UserClient.testValue creation,
correcting the comment to identify its actual declaration source, and removing
the meaningless XCTAssertTrue(true) or replacing it with a meaningful assertion;
update Projects/Domain/README.md lines 35-39 to document only
UserClient.testValue creation verification unless the test is expanded to
exercise unimplemented endpoint behavior.
In `@Projects/Domain/Tests/User/UserModelTests.swift`:
- Around line 5-10: Update the Gender tests around test_성별_rawValue와_동등성 to
verify its Codable contract with JSON encode/decode round-trip coverage,
matching the existing Interest and UserProfile test patterns. Preserve the
current rawValue and equality assertions while confirming each Gender case
survives encoding and decoding.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 76d7bfed-0f34-4980-bf79-7dc11ee20ec5
📒 Files selected for processing (13)
Projects/Domain/README.mdProjects/Domain/Sources/Auth/Client/AuthClient.swiftProjects/Domain/Sources/Auth/Error/AuthError.swiftProjects/Domain/Sources/Auth/Model/AuthProvider.swiftProjects/Domain/Sources/Auth/Model/AuthSession.swiftProjects/Domain/Sources/User/Client/UserClient.swiftProjects/Domain/Sources/User/Error/UserError.swiftProjects/Domain/Sources/User/Model/Gender.swiftProjects/Domain/Sources/User/Model/Interest.swiftProjects/Domain/Sources/User/Model/OnboardingDraft.swiftProjects/Domain/Sources/User/Model/UserProfile.swiftProjects/Domain/Tests/User/UserClientTests.swiftProjects/Domain/Tests/User/UserModelTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 변경 요약
UserClient, model, error) 추가📌 변경 내용
Domain Auth
Sources/Auth파일을Model/Client/Error하위로 이동Domain User
UserClient.completeOnboarding(OnboardingDraft) -> AuthSession포트 추가Gender,Interest,UserProfile,OnboardingDraft,UserError최소 계약 추가profileCompleted유지Domain Tests / Docs
UserClient.testValue검증 추가