Count a Rust function passed by path as used by the file that passes it - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A file's outline tells Jev which other files use each member (
used_by). Before this, JevGate counted only calls. A Rust function passed by path was invisible:compose::unconfirmed_unitsinfollow_ups(plan, files, compose::unconfirmed_units)is not a call. So JevGate's owncompose.rslistedfollow_ups.rsas the user of only 3 of the 8 follow-up selectors, which was the evidence a blind labeler used to call it a review-level split.The change.
compose::unconfirmed_units,Self::helper,module::f.Outcome::Clear,catalog::FILE_ORGANIZATION). Paths insideuseor inside a longer path don't count.Unit::passed. Only the callers map reads it, so the member calls sent in outlines, the callees sent in rechecks and the security traces don't change.passedstays empty outside.rsfiles.FILE_ORGANIZATIONrule version is now 23.Measured:
compose.rsnow lists all 8 selectors as used byfollow_ups.rs. Its first split answer moved from 0.75 to 0.80 on middle plus top, so the outline is a consider, where 0.24.0 cleared it through the kind of file. The group it names is still the large mixed one, so the location is weak.studio/src/server/convert.rs: review became a consider. It was labeled wrong as a review: one job, laid out in sections.src/util.rs: consider became a review. It was labeled right: a grab bag of helpers.Tests:
unconfirmed_unitsandSelf::name_ofbut not a call, a variant, or anything in a Python file.selectors::warm0as its user. This test fails without the change.Clippy (also 1.98) and
cargo +1.90.0 check --lockedpass. The self-check with the default gate exits 0, with no review or consider.Next: sending each candidate part's users with its part question (0.24.0's follow-up). "Used only by
follow_ups.rs" is the kind of evidence that separates a part to move.