fix(events): clear ?event= param when its modal closes - #535
Merged
Conversation
The query param added by the share-link "copy link" button was sticking around in the URL after closing the modal, even though the event was no longer on screen. Strip it via clearEventLinkParam() in both close handlers.
Deploying website with
|
| Latest commit: |
be94c28
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://93ede3da.website-aun.pages.dev |
| Branch Preview URL: | https://fix-events-clear-link-param.website-aun.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?event=<id>param added by the event modal's "copy link" button (feat(events): add shareable per-event links #534) was staying in the URL after the modal was closed, even though it no longer pointed at anything visible on the page.clearEventLinkParam()(src/utils/copyAnchorLink.ts), called from both/eventsand/events-new's modal close handlers, which strips theeventparam viahistory.replaceStatewhile preserving any other query params/hash.Test plan
.../events?event=<id>), confirm the modal auto-opens.?event=)./events-new.pnpm checkpasses.