fix spelling in package.json and in src/TeleSign.js - #1
Open
malikoum94 wants to merge 2 commits into
Open
Conversation
ts-release-engineering
pushed a commit
that referenced
this pull request
May 16, 2024
Merge in SDK/node_telesign_enterprise from feature/PD-86957 to master * commit 'f2a9625d394f222b5d3f1475cfa9e48f0cc01e8b': PD-86957: * Migrates to telesignsdk v3.0.0" * Removes unnecessary dev dependencies
Contributor
|
Hi @malikoum94 ! At the time that you raised this PR, the capitalization was indeed wrong. We have subsequently changed the official capitalization of our company name however, so the current state for that name is now correct. Regarding TeleBureau, you are correct that the capitalization is still wrong there. |
|
@malikoum94 While reviewing older PRs and community feedback, we re-checked the issues raised here with the engineering team. This has been resolved. As there are no outstanding changes required, we'll go ahead and close this out. Thanks for the contribution and for helping improve the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
like we say in issue the spelling of some paths are bad this PR fix this