DBT-417 allow HTML links in abstracts - #317
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eebcfcc6e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Allow simple html links in abstracts DBT-342 | ||
| MIR.Editor.HTML.Elements=%MIR.Editor.HTML.Elements% a[href] | ||
| # Allow accessible links in abstracts (DBT-417) | ||
| MIR.Editor.HTML.Elements=%MIR.Editor.HTML.Elements%;a[href] |
There was a problem hiding this comment.
Keep server HTML allowlist space-separated
When an abstract contains a link, the server-side MIR allowlist still expects MIR.Editor.HTML.Elements entries to be separated by whitespace, while only the TinyMCE allowlist on the next line is comma-separated. Appending ;a[href] makes the previous element and a[href] one token, so the editor can accept the link client-side but the backend sanitizer will not whitelist <a href> when the abstract is saved; use the same space-separated format as before for this property.
Useful? React with 👍 / 👎.
No description provided.