EnTypesManager v1 - #39
Open
SomeJakeGuy wants to merge 9 commits into
Open
Conversation
…e of param based on reading the source file structure.
…various EnemyParam functions.
Report for GLMP01_01 (edb2188 - 243f1b0)No changesReport for GLMJ01 (edb2188 - 243f1b0)No changesReport for GLME01 (edb2188 - 243f1b0)📈 Matched code: 17.87% (+0.04%, +880 bytes) ✅ 27 new matches
📈 3 improvements in unmatched items
Report for GLMP01_00 (edb2188 - 243f1b0)No changes |
Contributor
Author
|
okay should be good to merge now, apologies as i didnt realize my last commit was missing the symbols file changes associated lol. |
| mElement(&mParams, 0, "mElement", mElement.calcKeyCode("mElement")), | ||
| mCheckBox(&mParams, 0, "mCheckBox", mCheckBox.calcKeyCode("mCheckBox")), | ||
| mNormalItemTblId(&mParams, 0, "mNormalItemTblId", mNormalItemTblId.calcKeyCode("mNormalItemTblId")), | ||
| mTsuriItemTblId(&mParams, 0, "mTsuriItemTblId", mTsuriItemTblId.calcKeyCode("mTsuriItemTblId")), |
Owner
There was a problem hiding this comment.
isn't there a PARAM_INIT macro?
Contributor
Author
There was a problem hiding this comment.
Yes, but it didn't quite fit the needs here (I still should have made a macro though I just forgot ngl).
If we were to use, it needs to change from
#define PARAM_INIT(member, defaultValue) \ member(this, defaultValue, #member, calcKeyCode(#member))
to
#define PARAM_INIT(member, defaultValue) \ member(&mParams, defaultValue, #member, member.calcKeyCode(#member))
As this matches closer to what I saw from the ASM. Let me know if you want me to change this or make a new one based on my findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lots of matches, the most notable thing is that the split doesn't have .data / .sdata because it conflicts with EnAttackBase (it create some circular dependency thing), which may lead to a bigger problem outside of this PR specifically, so I deemed it out of scope for this PR and to be worried about later. In the header of EnTypesManager.hpp, I left the notes of what the data would look like.