Skip to content

chore(clang-format): Replace CPP_11(= delete) with FUNCTION_DELETE macro to help clang format#2885

Open
githubawn wants to merge 1 commit into
TheSuperHackers:mainfrom
githubawn:refactor/function-delete-macro
Open

chore(clang-format): Replace CPP_11(= delete) with FUNCTION_DELETE macro to help clang format#2885
githubawn wants to merge 1 commit into
TheSuperHackers:mainfrom
githubawn:refactor/function-delete-macro

Conversation

@githubawn

Copy link
Copy Markdown

In preparation for the clang format PR. This introduces FUNCTION_DELETE macro to fix clang-format.

@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown

Greptile Summary

This PR introduces a helper macro for deleted functions. The main changes are:

  • Adds FUNCTION_DELETE next to the existing C++11 compatibility macros.
  • Replaces CPP_11(= delete) declarations with FUNCTION_DELETE.
  • Applies the replacement across shared Core headers and mirrored Generals / Zero Hour headers.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The new macro expands the same way as the replaced pattern for these declarations.

Important Files Changed

Filename Overview
Dependencies/Utility/Utility/CppMacros.h Adds FUNCTION_DELETE with the same expansion behavior as the old CPP_11(= delete) pattern.
Core/GameEngine/Include/Common/INI.h Updates the non-copyable INI declarations to use FUNCTION_DELETE.
Core/GameEngine/Include/GameNetwork/NetCommandMsg.h Updates the non-copyable NetCommandDataChunk declarations to use FUNCTION_DELETE.
Core/Libraries/Source/WWVegas/WWMath/v3_rnd.h Updates private randomizer assignment operators to use FUNCTION_DELETE.
Core/Libraries/Source/profile/internal.h Updates non-copyable profiling lock declarations to use FUNCTION_DELETE.
Generals/Code/GameEngine/Include/GameLogic/Object.h Updates the blocked deleteInstance(Object*) overload to use FUNCTION_DELETE.
GeneralsMD/Code/GameEngine/Include/GameLogic/Object.h Updates the blocked Zero Hour deleteInstance(Object*) overload to use FUNCTION_DELETE.
Generals/Code/Libraries/Source/WWVegas/WW3D2/meshmdl.h Updates the private GapFillerClass assignment operator to use FUNCTION_DELETE.
GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/meshmdl.h Updates the mirrored Zero Hour GapFillerClass assignment operator to use FUNCTION_DELETE.

Reviews (1): Last reviewed commit: "refactor(cpp): introduce FUNCTION_DELETE..." | Re-trigger Greptile

@githubawn githubawn changed the title chore(clang-format): introduce FUNCTION_DELETE macro to fix clang-format chore(clang-format): introduce FUNCTION_DELETE macro Jul 17, 2026
@Skyaero42

Copy link
Copy Markdown

Can you elaborate on what problem this solves?

@xezon xezon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very professional

@xezon xezon changed the title chore(clang-format): introduce FUNCTION_DELETE macro chore(clang-format): Replace CPP_11(= delete) with FUNCTION_DELETE macro to help clang format Jul 18, 2026
@xezon xezon added the Refactor Edits the code with insignificant behavior changes, is never user facing label Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants