Add Laya request preprocessing - #43
Open
linear3735 wants to merge 7 commits into
Open
linear3735 wants to merge 7 commits into
linear3735 wants to merge 7 commits into
Conversation
The inventory mismatch reported only that the sets were unequal, so the most likely failure -- pointing the engine at a checkpoint that is not the frozen one -- said nothing about which tensor was wrong or in which direction. Both sets were already in scope. Report the expected-only names as "missing" and the checkpoint-only names as "unexpected", sorted, so the message is deterministic. The neighbouring errors already name their tensor (duplicate expected tensor, shape mismatch, unsupported dtype); this was the one that did not. Adds a CPU test over the synthetic safetensors fixture that asserts both directions and the ordering. fmt, clippy -D warnings, and the workspace tests pass; the checkpoint test that exercises this path still passes against the frozen checkpoint.
linear3735
marked this pull request as ready for review
September 30, 2026 02:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Pack English Laya requests into token rows, option-marker positions, question types and usage counts. Preserve question and option order and apply Laya 0.3.20's truncation rules.
Depends on #21; merge it first. Until then, GitHub shows the checkpoint changes too. This PR's diff contains 432 changed core/configuration lines, conservatively including the JSON regression test. Separate test files, docs and Cargo.lock are excluded. Refs #14.
Also preserve Cua-S1 JSON number parsing and Python float formatting when Laya enables
serde_json/arbitrary_precision. Without this fix, three existing Cua-S1 tests fail in the combined workspace.Tests now live under the repository-root
tests/directory. Cargo target names and test coverage are unchanged.Test Plan
Run workspace tests, fmt, strict Clippy and a release build. Compare packed inputs against the frozen 17-case Laya reference. CI downloads the tokenizer and reference; the test checks both hashes before comparison.
System1-Omni Version / Commit:
99c1d1200e0e7f704296dcdf30834b42452431d3; incremental base219808b.Test Result
arbitrary_precision; that code is unchanged.Rust CI, Docs build and benchmark harness tests passed for this update.
Self-review
Before marking this PR ready for review or requesting maintainer review, complete
the self-review checklist.
Keep the PR in draft while this work is incomplete.
For agent assistance, use the optional precheck-pr skill.