Keep Laya weights and workspace on CUDA - #48
Draft
linear3735 wants to merge 17 commits into
Draft
linear3735 wants to merge 17 commits into
linear3735 wants to merge 17 commits into
Conversation
The inventory mismatch reported only that the sets were unequal, so the most likely failure -- pointing the engine at a checkpoint that is not the frozen one -- said nothing about which tensor was wrong or in which direction. Both sets were already in scope. Report the expected-only names as "missing" and the checkpoint-only names as "unexpected", sorted, so the message is deterministic. The neighbouring errors already name their tensor (duplicate expected tensor, shape mismatch, unsupported dtype); this was the one that did not. Adds a CPU test over the synthetic safetensors fixture that asserts both directions and the ordering. fmt, clippy -D warnings, and the workspace tests pass; the checkpoint test that exercises this path still passes against the frozen checkpoint.
This was referenced Sep 30, 2026
added 11 commits
October 1, 2026 12:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Upload Laya's 205 used tensors once and allocate 17 reusable workspace buffers. Validate shapes before allocation and release partial allocations on failure.
Part of #14. Depends on #21 and #47. Kept in draft until those merge.
The diff against
maincurrently includes those dependencies. Review this increment: 190 core/configuration lines for residency and workspace.Tests now live under the repository-root
tests/directory. Cargo target names and test coverage are unchanged.Test Plan
cargo fmt --all --check cargo clippy --workspace --locked --all-targets -- -D warnings cargo test --workspace --locked cargo build --workspace --release --lockedOn H800, compare uploaded tensors with the Torch conversion oracle and check workspace capacity and reuse. Reproduction commands are in
src/models/laya/README.md.System1-Omni Version / Commit:
2f5ff4b; incremental base9ef493e.Test Result
fmt, strict Clippy, release build passed locally; 37 CPU tests passed and 7 checkpoint/GPU tests were skipped. The earlier H800 validation below uses the same Laya and CUDA source; GPU tests were not rerun for this test-directory update.
Rust CI, Docs build and benchmark harness tests passed for this update.
Self-review
Before marking this PR ready for review or requesting maintainer review, complete
the self-review checklist.
Keep the PR in draft while this work is incomplete.
For agent assistance, use the optional precheck-pr skill.