Conversation
A compatibility table for each model and worker on main: CPU, NVIDIA CUDA and Apple Metal, with requirements and validation status. Add the page and the two Cua-S1 recipes to the site nav, link the page from the README, and update the Cua-S1 status that still called the multimodal adapter deferred. Signed-off-by: Tianyao Wu <rayroy31@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The second part of #45, as split there with MinhaoLi0318, who takes the quick start and installation pages.
docs/supported-models.md: the compatibility table [Doc]: Community help wanted — documentation site and GitHub Pages #45 asks for. Each model and worker onmainagainst CPU, NVIDIA CUDA and Apple Metal, with its requirements and a status (Validated, Unverified, Planned, Not supported) that links the recipe, the merged PR or the tracking issue behind it. Models still being added are linked through thenew modelissue label.mkdocs.yml: nav entries for the page and for the two Cua-S1 recipes, which were built but not in the nav.README.md: one line linking the page, in place of "CUDA and Metal coverage will be documented per model". The table rows are left to the model PRs.src/models/cua_s1/README.md: on Add Cua-S1 0.2 multimodal CUDA worker with upstream parity #12 you asked to keep the Python multimodal worker as a correctness reference and said "We should update the existing Cua-S1 plan to reflect this direction as well." The status still called themultimodaladapter deferred; it now points to that reference worker and says native execution of the adapter is not covered yet.MinhaoLi0318's RTX 5090 and M5 Pro checks can update the status cells once they land with his pages.
Test Plan
System1-Omni Version / Commit:
2e33ef7, on maince38770.mkdocs build --strictwithdocs/requirements.txt.git merge-tree), compared with the same merges intomain.ce38770, with ports 8831 and 8832, on one machine: AMD Ryzen Threadripper PRO 7965WX, RTX 6000 Ada (sm_89), Ubuntu 22.04, driver 595.91.07, CUDA 13.2, rustc 1.97.0. The Laya worker was installed as its recipe says. The two Cua-S1 workers used an existing environment that matchesrequirements-text.txtand the pinned weights, including a merged export fromexport_text_merged.py.Test Result
docs/benchmarks/cua-s1-cuda-graphs/README.mdis.main.compare_with_backend.pypassed all five checks.textworkers on CUDA; the cells link the merged PRs that first recorded them.Self-review
Before marking this PR ready for review or requesting maintainer review, complete
the self-review checklist.
Keep the PR in draft while this work is incomplete.
For agent assistance, use the optional precheck-pr skill.