Hold the add-project intent until an environment exists - #124
Merged
Conversation
Opening add-project is a one-shot intent, and it was consumed the moment the palette mounted, against whatever environment data had hydrated by then. A click during startup landed on an empty list: the flow dead-ended with guidance meant for genuinely environment-less sessions, and the arriving environments a moment later could not revive it. This is also why the palette browser suites failed most local runs. The intent now waits for the options to exist (the effect re-runs when they arrive; closing the palette still cancels), while hosted-static tabs keep their immediate pairing guidance. Also teaches the suite's waitFor helpers to report what the palette actually rendered at timeout, so the next residual failure diagnoses itself.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root-causes the escalating palette suite failures (issue #117's second layer, after the ghost-click fix in #121): the add-project open intent was consumed unconditionally on palette mount, branching on whatever environment data existed at that instant. Clicking during startup hydration dead-ended the flow permanently. The intent now waits for environment options (effect re-runs on arrival; palette close cancels; hosted-static proceeds immediately to pairing guidance).
Local validation: suite pass rate went from 1/5 to 5/6; the residual create-folder failure now self-diagnoses via lazy timeout messages that report the palette's actual rendered state.
Real-user impact beyond tests: clicking Add a project during app startup no longer produces an unrecoverable dead palette.